Skip to content

Allow end users to add a family name to the EESSI module #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ocaisa merged 5 commits into from
Jul 25, 2025
Merged

Allow end users to add a family name to the EESSI module #43

ocaisa merged 5 commits into from
Jul 25, 2025

Conversation

@bedroge
Copy link
Contributor

@bedroge bedroge commented Jul 24, 2025

Assuming sites have a family("stack") in the meta module for the local stack, this allows them to do the following:

$ export EESSI_MODULE_FAMILY_NAME=stack
$ ml EESSI/2023.06
$ ml mystack/1.2.3

Lmod is automatically replacing "EESSI/2023.06" with "mystack/1.2.3".

@bedroge
Copy link
Contributor Author

bedroge commented Jul 24, 2025 •
edited
Loading 

=====================================================================================================
RUNNING TESTS FOR SHELL: bash
=====================================================================================================
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/amd/zen3/software/Python/3.10.8-GCCcore-12.2.0/bin/python
test #1 "bash -c 'source init/lmod/bash' 2>&1 " failed:
	expected "EESSI/2023.06 loaded successfully"
	got "Module for EESSI/2023.06 loaded successfully"
1 of 5 source_eessi_bash tests failed in 10.689s.

This was changed in #41, but for some reason the CI in that PR didn't catch it (cc @ocaisa ).

edit: ah, I think it's using the modulefile from the CVMFS repo. Now that #41 is deployed, it's failing.

https://github.com/EESSI/software-layer-scripts/blob/main/init/lmod/bash#L7

ocaisa
ocaisa reviewed Jul 24, 2025
View reviewed changes
@ocaisa
Copy link
Member

ocaisa commented Jul 24, 2025 

=====================================================================================================
RUNNING TESTS FOR SHELL: bash
=====================================================================================================
/cvmfs/software.eessi.io/versions/2023.06/software/linux/x86_64/amd/zen3/software/Python/3.10.8-GCCcore-12.2.0/bin/python
test #1 "bash -c 'source init/lmod/bash' 2>&1 " failed:
	expected "EESSI/2023.06 loaded successfully"
	got "Module for EESSI/2023.06 loaded successfully"
1 of 5 source_eessi_bash tests failed in 10.689s.

This was changed in #41, but for some reason the CI in that PR didn't catch it (cc @ocaisa ).

edit: ah, I think it's using the modulefile from the CVMFS repo. Now that #41 is deployed, it's failing.

https://github.com/EESSI/software-layer-scripts/blob/main/init/lmod/bash#L7

I fixed that CI in #42 but you are right that if possible it should actually be being run with the module file in the repository (might be tricky to do in practice)

@bedroge
Copy link
Contributor Author

bedroge commented Jul 24, 2025

bot: build repo:eessi.io-2023.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2
bot: build repo:eessi.io-2025.06-software instance:eessi-bot-mc-aws arch:x86_64/amd/zen2

@eessi-bot-aws
Copy link

eessi-bot-aws bot commented Jul 24, 2025 •
edited
Loading

New job on instance eessi-bot-mc-aws for CPU micro-architecture x86_64-amd-zen2 for repository eessi.io-2023.06-software in job dir /project/def-users/SHARED/jobs/2025.07/pr_43/78255

date job status comment
Jul 24 19:14:54 UTC 2025 submitted job id 78255 awaits release by job manager
Jul 24 19:15:40 UTC 2025 released job awaits launch by Slurm scheduler
Jul 24 19:16:44 UTC 2025 running job 78255 is running
Jul 24 19:20:49 UTC 2025 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-78255.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.gz created!
Artefacts
eessi-2023.06-software-linux-x86_64-amd-zen2-17533845940.tar.gzsize: 0 MiB (3334 bytes)
entries: 1
modules under 2023.06/software/linux/x86_64/amd/zen2/modules/all
no module files in tarball
software under 2023.06/software/linux/x86_64/amd/zen2/software
no software packages in tarball
reprod directories under 2023.06/software/linux/x86_64/amd/zen2/reprod
no reprod directories in tarball
other under 2023.06/software/linux/x86_64/amd/zen2
2023.06/init/modules/EESSI/2023.06.lua
Jul 24 19:20:49 UTC 2025 test result
😁 SUCCESS (click triangle for details)
ReFrame Summary
[ OK ] ( 1/10) EESSI_LAMMPS_lj %device_type=cpu %module_name=LAMMPS/29Aug2024-foss-2023b-kokkos %scale=1_node /aeb2d9df @BotBuildTests:x86_64_amd_zen2+default
P: perf: 268.929 timesteps/s (r:0, l:None, u:None)
[ OK ] ( 2/10) EESSI_LAMMPS_lj %device_type=cpu %module_name=LAMMPS/2Aug2023_update2-foss-2023a-kokkos %scale=1_node /04ff9ece @BotBuildTests:x86_64_amd_zen2+default
P: perf: 447.763 timesteps/s (r:0, l:None, u:None)
[ OK ] ( 3/10) EESSI_OSU_coll %benchmark_info=mpi.collective.osu_allreduce %module_name=OSU-Micro-Benchmarks/7.2-gompi-2023b %scale=1_node %device_type=cpu /775175bf @BotBuildTests:x86_64_amd_zen2+default
P: latency: 1.84 us (r:0, l:None, u:None)
[ OK ] ( 4/10) EESSI_OSU_coll %benchmark_info=mpi.collective.osu_allreduce %module_name=OSU-Micro-Benchmarks/7.1-1-gompi-2023a %scale=1_node %device_type=cpu /52707c40 @BotBuildTests:x86_64_amd_zen2+default
P: latency: 1.81 us (r:0, l:None, u:None)
[ OK ] ( 5/10) EESSI_OSU_coll %benchmark_info=mpi.collective.osu_alltoall %module_name=OSU-Micro-Benchmarks/7.2-gompi-2023b %scale=1_node %device_type=cpu /b1aacda9 @BotBuildTests:x86_64_amd_zen2+default
P: latency: 3.91 us (r:0, l:None, u:None)
[ OK ] ( 6/10) EESSI_OSU_coll %benchmark_info=mpi.collective.osu_alltoall %module_name=OSU-Micro-Benchmarks/7.1-1-gompi-2023a %scale=1_node %device_type=cpu /c6bad193 @BotBuildTests:x86_64_amd_zen2+default
P: latency: 4.21 us (r:0, l:None, u:None)
[ OK ] ( 7/10) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_latency %module_name=OSU-Micro-Benchmarks/7.2-gompi-2023b %scale=1_node /15cad6c4 @BotBuildTests:x86_64_amd_zen2+default
P: latency: 0.59 us (r:0, l:None, u:None)
[ OK ] ( 8/10) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_latency %module_name=OSU-Micro-Benchmarks/7.1-1-gompi-2023a %scale=1_node /6672deda @BotBuildTests:x86_64_amd_zen2+default
P: latency: 0.57 us (r:0, l:None, u:None)
[ OK ] ( 9/10) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_bw %module_name=OSU-Micro-Benchmarks/7.2-gompi-2023b %scale=1_node /2a9a47b1 @BotBuildTests:x86_64_amd_zen2+default
P: bandwidth: 7344.43 MB/s (r:0, l:None, u:None)
[ OK ] (10/10) EESSI_OSU_pt2pt_CPU %benchmark_info=mpi.pt2pt.osu_bw %module_name=OSU-Micro-Benchmarks/7.1-1-gompi-2023a %scale=1_node /1b24ab8e @BotBuildTests:x86_64_amd_zen2+default
P: bandwidth: 7376.82 MB/s (r:0, l:None, u:None)
[ PASSED ] Ran 10/10 test case(s) from 10 check(s) (0 failure(s), 0 skipped, 0 aborted)
Details
✅ job output file slurm-78255.out
✅ no message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Jul 25 08:28:32 UTC 2025 uploaded transfer of eessi-2023.06-software-linux-x86_64-amd-zen2-17533845940.tar.gz to S3 bucket succeeded

@eessi-bot-aws
Copy link

eessi-bot-aws bot commented Jul 24, 2025 •
edited
Loading

New job on instance eessi-bot-mc-aws for CPU micro-architecture x86_64-amd-zen2 for repository eessi.io-2025.06-software in job dir /project/def-users/SHARED/jobs/2025.07/pr_43/78256

date job status comment
Jul 24 19:14:58 UTC 2025 submitted job id 78256 awaits release by job manager
Jul 24 19:15:38 UTC 2025 released job awaits launch by Slurm scheduler
Jul 24 19:16:42 UTC 2025 running job 78256 is running
Jul 24 19:17:46 UTC 2025 finished
😁 SUCCESS (click triangle for details)
Details
✅ job output file slurm-78256.out
✅ no message matching FATAL:
✅ no message matching ERROR:
✅ no message matching FAILED:
✅ no message matching required modules missing:
✅ found message(s) matching No missing installations
✅ found message matching .tar.gz created!
Artefacts
eessi-2025.06-software-linux-x86_64-amd-zen2-17533845630.tar.gzsize: 0 MiB (3339 bytes)
entries: 1
modules under 2025.06/software/linux/x86_64/amd/zen2/modules/all
no module files in tarball
software under 2025.06/software/linux/x86_64/amd/zen2/software
no software packages in tarball
reprod directories under 2025.06/software/linux/x86_64/amd/zen2/reprod
no reprod directories in tarball
other under 2025.06/software/linux/x86_64/amd/zen2
2025.06/init/modules/EESSI/2025.06.lua
Jul 24 19:17:46 UTC 2025 test result
😢 FAILURE (click triangle for details)
Reason
EESSI test suite was not run, test step itself failed to execute.
Details
✅ job output file slurm-78256.out
❌ found message matching ERROR:
✅ no message matching [\s*FAILED\s*].*Ran .* test case
Jul 25 08:28:40 UTC 2025 uploaded transfer of eessi-2025.06-software-linux-x86_64-amd-zen2-17533845630.tar.gz to S3 bucket succeeded

@bedroge bedroge added ready-to-deploy 2025.06-software.eessi.io 2025.06 version of software.eessi.io 2023.06-software.eessi.io 2023.06 version of software.eessi.io labels Jul 24, 2025
ocaisa
ocaisa approved these changes Jul 25, 2025
View reviewed changes
Copy link
Member

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocaisa
Copy link
Member

ocaisa commented Jul 25, 2025

I'm not going to worry about the failing CI, this is fixed in #42

@ocaisa ocaisa merged commit e7f35e5 into EESSI:main Jul 25, 2025
54 of 55 checks passed
@bedroge bedroge deleted the modulefile_family branch July 25, 2025 09:49
@bedroge bedroge mentioned this pull request Aug 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocaisa ocaisa ocaisa approved these changes

Assignees

No one assigned

Labels

2023.06-software.eessi.io 2023.06 version of software.eessi.io 2025.06-software.eessi.io 2025.06 version of software.eessi.io bot:deploy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bedroge @ocaisa